Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: revert backup progress (#53914) #58697

Open
wants to merge 1 commit into
base: release-8.5
Choose a base branch
from
Open

br: revert backup progress (#53914) #58697

wants to merge 1 commit into from
+147 −101

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53914

What problem does this PR solve?

Issue Number: ref #53778

Problem Summary:
get region counts for each range takes too much time when there are 1 million tables.

What changed and how does it work?

revert back to use range unit progress

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Jan 6, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 6, 2025
Merged
13 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.73684% with 42 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@7362832). Learn more about missing BASE report.

Additional details and impacted files 
@@               Coverage Diff                @@
##             release-8.5     #58697   +/-   ##
================================================
  Coverage               ?   56.9221%           
================================================
  Files                  ?       1770           
  Lines                  ?     627064           
  Branches               ?          0           
================================================
  Hits                   ?     356938           
  Misses                 ?     245934           
  Partials               ?      24192
Flag Coverage Δ
integration 36.8231% <43.4210%> (?)
unit 72.6078% <32.8947%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2341% <0.0000%> (?)

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 9, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-09 03:44:39.113113297 +0000 UTC m=+411622.401945002: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

Assignees

@Leavrth Leavrth

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @BornChanger @Leavrth